Issue 203 auto switch cycle mode #229
Conversation
|
Just realized that I missed this. I'll validate in the next day or so. But the code changes look OK with a quick glance. |
|
I'm still wondering whether it would help raising an alarm if for some reason we can't change the cycle setting, in addition to the debug log statement. (the service call will of course still fail with an appropriate message) |
|
I agree that an alarm is warranted if the set-operation fails and the current cycle is |
There was a problem hiding this comment.
@yai-rosejo
I just tested and it works great.
Two things:
- It would nice to implement that alarm.
- I think it should do a final check to
Ros_Controller_IsContinuousCycleto verify the setting was applied. This would require a call toRos_Controller_IoStatusUpdateto fetch the value.
If you're tied up with Matt, let me know and I'll implement the changes.
|
Friendly ping? |
|
Apologies for the delay. I will look at this again later in the week. |
gavanderhoorn
force-pushed
the
issue_203_auto_switch_cycle
branch
from
13d491f
to
a461aee
Compare
|
I've added (a) named constant(s) in a461aee and rebased on top of |
|
build-check was verified locally. |
#203
A continuation of the discussion and development of the cycle mode. These small changes allow Ros_MotionControl_StartMotionMode() to verify that the system is in a continuous cycle mode, and if it isn't it will try to set the cycle mode to continuous.